Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-933: make sure flows collector CRD has the right namespace for OCP (backport 1.2) #318

Closed
wants to merge 1 commit into from

Conversation

msherif1234
Copy link
Contributor

Signed-off-by: msherif1234 mmahmoud@redhat.com
(cherry picked from commit 32f7ad3)

Signed-off-by: msherif1234 <mmahmoud@redhat.com>
(cherry picked from commit 32f7ad3)
@openshift-ci
Copy link

openshift-ci bot commented Mar 31, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jpinsonneau for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@msherif1234 msherif1234 changed the title make sure flows collector CRD has the right namespace for OCP (backport 1.2) NETOBSERV-933: make sure flows collector CRD has the right namespace for OCP (backport 1.2) Mar 31, 2023
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Mar 31, 2023

@msherif1234: This pull request references NETOBSERV-933 which is a valid jira issue.

In response to this:

Signed-off-by: msherif1234 mmahmoud@redhat.com
(cherry picked from commit 32f7ad3)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-1.2@ac32da4). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             release-1.2     #318   +/-   ##
==============================================
  Coverage               ?   50.41%           
==============================================
  Files                  ?       43           
  Lines                  ?     5096           
  Branches               ?        0           
==============================================
  Hits                   ?     2569           
  Misses                 ?     2318           
  Partials               ?      209           
Flag Coverage Δ
unittests 50.41% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@msherif1234
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Mar 31, 2023
@github-actions
Copy link

New images:

  • quay.io/netobserv/network-observability-operator:5daa926
  • quay.io/netobserv/network-observability-operator-bundle:v0.0.0-5daa926
  • quay.io/netobserv/network-observability-operator-catalog:v0.0.0-5daa926

They will expire after two weeks.

Catalog source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-5daa926
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

@jotak
Copy link
Member

jotak commented Mar 31, 2023

tested with make deploy 👍
/lgtm

@msherif1234
Copy link
Contributor Author

/hold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold jira/valid-reference lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants