Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] NETOBSERV-844 skip empty cert paths #321

Merged

Conversation

jpinsonneau
Copy link
Contributor

backport of 61cb3da

@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-1.2@bce2e23). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             release-1.2     #321   +/-   ##
==============================================
  Coverage               ?   50.47%           
==============================================
  Files                  ?       43           
  Lines                  ?     5080           
  Branches               ?        0           
==============================================
  Hits                   ?     2564           
  Misses                 ?     2311           
  Partials               ?      205           
Flag Coverage Δ
unittests 50.47% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Amoghrd
Copy link
Contributor

Amoghrd commented Apr 4, 2023

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Apr 4, 2023
@github-actions
Copy link

github-actions bot commented Apr 4, 2023

New images:

  • quay.io/netobserv/network-observability-operator:3edb801
  • quay.io/netobserv/network-observability-operator-bundle:v0.0.0-3edb801
  • quay.io/netobserv/network-observability-operator-catalog:v0.0.0-3edb801

They will expire after two weeks.

Catalog source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-3edb801
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

@Amoghrd
Copy link
Contributor

Amoghrd commented Apr 4, 2023

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved QE has approved this pull request label Apr 4, 2023
@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Apr 5, 2023
@jotak
Copy link
Member

jotak commented Apr 5, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 5, 2023
@jpinsonneau
Copy link
Contributor Author

/approve

@openshift-ci
Copy link

openshift-ci bot commented Apr 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpinsonneau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Apr 5, 2023
@openshift-merge-robot openshift-merge-robot merged commit 54839a1 into netobserv:release-1.2 Apr 5, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm qe-approved QE has approved this pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants