NETOBSERV-1062: Add TCP drop and DNS tracking to netobserv operator #331

msherif1234 · 2023-04-28T22:06:23Z

TCPdrop tracepoint need special volume mount and added a flag to control TCPdrop feature
by default its turned off

openshift-ci-robot · 2023-04-28T22:06:26Z

@msherif1234: This pull request references NETOBSERV-979 which is a valid jira issue.

In response to this:

TCPdrop tracepoint need special volume mount and added a flag to control TCPdrop feature its default to true

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-04-28T22:32:12Z

@msherif1234: This pull request references NETOBSERV-979 which is a valid jira issue.

In response to this:

TCPdrop tracepoint need special volume mount and added a flag to control TCPdrop feature
by default its turned off

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

codecov · 2023-04-28T22:39:27Z

Codecov Report

Merging #331 (93a46e1) into main (a4a3c26) will decrease coverage by 0.85%.
The diff coverage is 51.79%.

❗ Current head 93a46e1 differs from pull request most recent head def94dc. Consider uploading reports for the commit def94dc to get more accurate results

@@            Coverage Diff             @@
##             main     #331      +/-   ##
==========================================
- Coverage   54.52%   53.67%   -0.85%     
==========================================
  Files          44       44              
  Lines        5423     5559     +136     
==========================================
+ Hits         2957     2984      +27     
- Misses       2259     2359     +100     
- Partials      207      216       +9

Flag	Coverage Δ
unittests	`53.67% <51.79%> (-0.85%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
api/v1alpha1/flowcollector_webhook.go	`0.00% <0.00%> (ø)`
api/v1alpha1/zz_generated.conversion.go	`0.26% <0.00%> (+<0.01%)`	⬆️
api/v1beta1/flowcollector_types.go	`100.00% <ø> (ø)`
...ntrollers/ebpf/internal/permissions/permissions.go	`45.23% <0.00%> (-1.39%)`	⬇️
controllers/consoleplugin/consoleplugin_objects.go	`95.42% <33.33%> (-1.64%)`	⬇️
pkg/helper/flowcollector.go	`66.66% <40.00%> (-3.47%)`	⬇️
controllers/flowlogspipeline/flp_common_objects.go	`81.31% <51.11%> (-5.28%)`	⬇️
controllers/ebpf/agent_controller.go	`70.70% <58.77%> (-10.36%)`	⬇️
api/v1beta1/zz_generated.deepcopy.go	`53.77% <100.00%> (+1.05%)`	⬆️

msherif1234 · 2023-04-29T13:48:32Z

/ok-to-test

github-actions · 2023-04-29T13:53:14Z

New images:

quay.io/netobserv/network-observability-operator:b82d0dc
quay.io/netobserv/network-observability-operator-bundle:v0.0.0-b82d0dc
quay.io/netobserv/network-observability-operator-catalog:v0.0.0-b82d0dc

They will expire after two weeks.

Catalog source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-b82d0dc
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

msherif1234 · 2023-04-29T18:15:36Z

/ok-to-test

github-actions · 2023-04-29T18:20:59Z

New images:

quay.io/netobserv/network-observability-operator:cbad56c
quay.io/netobserv/network-observability-operator-bundle:v0.0.0-cbad56c
quay.io/netobserv/network-observability-operator-catalog:v0.0.0-cbad56c

They will expire after two weeks.

Catalog source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-cbad56c
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

msherif1234 · 2023-05-01T14:09:09Z

/ok-to-test

github-actions · 2023-05-01T14:13:43Z

New images:

quay.io/netobserv/network-observability-operator:e760a39
quay.io/netobserv/network-observability-operator-bundle:v0.0.0-e760a39
quay.io/netobserv/network-observability-operator-catalog:v0.0.0-e760a39

They will expire after two weeks.

Catalog source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-e760a39
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

controllers/ebpf/agent_controller.go

controllers/flowlogspipeline/flp_common_objects.go

jpinsonneau · 2023-05-02T10:58:38Z

After testing this on clusterbot 4.13 aws,large with enableTCPDrop: true, I get the following error:

Error creating: pods "netobserv-ebpf-agent-" is forbidden: unable to validate against any security context constraint: [provider "anyuid": Forbidden: not usable by user or serviceaccount, provider restricted-v2: .spec.securityContext.hostNetwork: Invalid value: true: Host network is not allowed to be used, spec.volumes[0]: Invalid value: "hostPath": hostPath volumes are not allowed to be used, spec.containers[0].securityContext.runAsUser: Invalid value: 0: must be in the ranges: [1000710000, 1000719999], spec.containers[0].securityContext.privileged: Invalid value: true: Privileged containers are not allowed, spec.containers[0].securityContext.hostNetwork: Invalid value: true: Host network is not allowed to be used, provider "restricted": Forbidden: not usable by user or serviceaccount, provider "nonroot-v2": Forbidden: not usable by user or serviceaccount, provider "nonroot": Forbidden: not usable by user or serviceaccount, provider "hostmount-anyuid": Forbidden: not usable by user or serviceaccount, provider "machine-api-termination-handler": Forbidden: not usable by user or serviceaccount, provider "hostnetwork-v2": Forbidden: not usable by user or serviceaccount, provider "hostnetwork": Forbidden: not usable by user or serviceaccount, provider "hostaccess": Forbidden: not usable by user or serviceaccount, provider "node-exporter": Forbidden: not usable by user or serviceaccount, provider "privileged": Forbidden: not usable by user or serviceaccount]

  relatedImages:
    - image: 'quay.io/netobserv/netobserv-ebpf-agent:adfa724'
      name: ebpf-agent
    - image: 'quay.io/netobserv/flowlogs-pipeline:06ebf5e'
      name: flowlogs-pipeline
    - image: 'quay.io/netobserv/network-observability-console-plugin:main'
      name: console-plugin

docs/FlowCollector.md

msherif1234 · 2023-05-02T14:26:17Z

/ok-to-test

github-actions · 2023-05-02T14:32:20Z

New images:

quay.io/netobserv/network-observability-operator:fa97162
quay.io/netobserv/network-observability-operator-bundle:v0.0.0-fa97162
quay.io/netobserv/network-observability-operator-catalog:v0.0.0-fa97162

They will expire after two weeks.

Catalog source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-fa97162
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

memodi · 2023-07-13T18:07:58Z

could we list these 3 options in flowcollector yaml config in order:

never mind, I think it follows alphabetical order.

msherif1234 · 2023-07-13T21:32:50Z

/ok-to-test

github-actions · 2023-07-13T21:38:42Z

New images:

quay.io/netobserv/network-observability-operator:ccabe88
quay.io/netobserv/network-observability-operator-bundle:v0.0.0-ccabe88
quay.io/netobserv/network-observability-operator-catalog:v0.0.0-ccabe88

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:ccabe88 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-ccabe88

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-ccabe88
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

msherif1234 · 2023-07-14T10:53:22Z

/ok-to-test

github-actions · 2023-07-14T10:58:40Z

New images:

quay.io/netobserv/network-observability-operator:13e79b8
quay.io/netobserv/network-observability-operator-bundle:v0.0.0-13e79b8
quay.io/netobserv/network-observability-operator-catalog:v0.0.0-13e79b8

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:13e79b8 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-13e79b8

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-13e79b8
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

msherif1234 · 2023-07-14T11:20:41Z

/ok-to-test

github-actions · 2023-07-14T11:25:28Z

New images:

quay.io/netobserv/network-observability-operator:63a535e
quay.io/netobserv/network-observability-operator-bundle:v0.0.0-63a535e
quay.io/netobserv/network-observability-operator-catalog:v0.0.0-63a535e

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:63a535e make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-63a535e

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-63a535e
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

Signed-off-by: msherif1234 <mmahmoud@redhat.com>

msherif1234 · 2023-07-14T11:52:00Z

/ok-to-test

github-actions · 2023-07-14T11:56:33Z

New images:

quay.io/netobserv/network-observability-operator:14a6c81
quay.io/netobserv/network-observability-operator-bundle:v0.0.0-14a6c81
quay.io/netobserv/network-observability-operator-catalog:v0.0.0-14a6c81

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:14a6c81 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-14a6c81

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-14a6c81
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

This PR depends on PR netobserv#331 so 331 need to be merged 1st Signed-off-by: msherif1234 <mmahmoud@redhat.com>

jotak · 2023-07-17T07:30:16Z

/lgtm

This PR depends on PR netobserv#331 so 331 need to be merged 1st Signed-off-by: msherif1234 <mmahmoud@redhat.com>

* NETOBSERV-979: Add TCP drop to netobserv operator Signed-off-by: msherif1234 <mmahmoud@redhat.com> * Add scc rbac to fix issues with scc constraint when creating ebpf pod in privileged mode we got Error creating: pods "netobserv-ebpf-agent-" is forbidden: unable to validate against any security context constraint Signed-off-by: msherif1234 <mmahmoud@redhat.com> * Add DNS tracker operator changes Signed-off-by: msherif1234 <mmahmoud@redhat.com> * Address PR review comments Signed-off-by: msherif1234 <mmahmoud@redhat.com> * list enabled features in console plugin configmap * fix TcpDrop fields case * NETOBSERV-1191: fix updating tcpdrop and dns configs Signed-off-by: msherif1234 <mmahmoud@redhat.com> * fix linter complicity error Signed-off-by: msherif1234 <mmahmoud@redhat.com> * NETOBSERV-1190: use DNS latency instead of TS This PR depends on PR #331 so 331 need to be merged 1st Signed-off-by: msherif1234 <mmahmoud@redhat.com> --------- Signed-off-by: msherif1234 <mmahmoud@redhat.com> Co-authored-by: Julien Pinsonneau <91894519+jpinsonneau@users.noreply.github.com>

msherif1234 · 2023-07-17T14:23:15Z

already been done via #395

openshift-ci-robot added the jira/valid-reference label Apr 28, 2023

msherif1234 force-pushed the tcpdrop branch from 30f4097 to 9ac4f28 Compare April 28, 2023 22:31

openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Apr 29, 2023

msherif1234 force-pushed the tcpdrop branch from 9ac4f28 to c0e211c Compare April 29, 2023 18:11

github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Apr 29, 2023

openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Apr 29, 2023

msherif1234 force-pushed the tcpdrop branch from c0e211c to 808e9e8 Compare May 1, 2023 14:04

github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label May 1, 2023

openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label May 1, 2023

jpinsonneau reviewed May 2, 2023

View reviewed changes

controllers/ebpf/agent_controller.go Outdated Show resolved Hide resolved

jpinsonneau reviewed May 2, 2023

View reviewed changes

controllers/flowlogspipeline/flp_common_objects.go Outdated Show resolved Hide resolved

eranra reviewed May 2, 2023

View reviewed changes

docs/FlowCollector.md Show resolved Hide resolved

jpinsonneau mentioned this pull request May 2, 2023

NETOBSERV-1064: TCP drop & DNS tracking netobserv/network-observability-console-plugin#324

Closed

6 tasks

msherif1234 force-pushed the tcpdrop branch from 808e9e8 to 24f0940 Compare May 2, 2023 12:46

github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label May 2, 2023

openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label May 2, 2023

openshift-merge-robot added the needs-rebase label May 9, 2023

github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label May 9, 2023

openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 13, 2023

github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 14, 2023

openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 14, 2023

msherif1234 force-pushed the tcpdrop branch from f7f706e to 93a46e1 Compare July 14, 2023 11:20

github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 14, 2023

openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 14, 2023

msherif1234 added 2 commits July 14, 2023 07:51

NETOBSERV-1191: fix updating tcpdrop and dns configs

b2a29b1

Signed-off-by: msherif1234 <mmahmoud@redhat.com>

fix linter complicity error

def94dc

Signed-off-by: msherif1234 <mmahmoud@redhat.com>

msherif1234 force-pushed the tcpdrop branch from 93a46e1 to def94dc Compare July 14, 2023 11:51

github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 14, 2023

openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 14, 2023

msherif1234 added a commit to msherif1234/network-observability-operator that referenced this pull request Jul 14, 2023

NETOBSERV-1190: use DNS latency instead of TS

500c2c6

This PR depends on PR netobserv#331 so 331 need to be merged 1st Signed-off-by: msherif1234 <mmahmoud@redhat.com>

msherif1234 mentioned this pull request Jul 14, 2023

NETOBSERV-1190: change DNS to use latency instead of TS #395

Merged

openshift-ci bot assigned jotak Jul 17, 2023

openshift-ci bot added the lgtm label Jul 17, 2023

msherif1234 added a commit to msherif1234/network-observability-operator that referenced this pull request Jul 17, 2023

NETOBSERV-1190: use DNS latency instead of TS

01ae4ec

This PR depends on PR netobserv#331 so 331 need to be merged 1st Signed-off-by: msherif1234 <mmahmoud@redhat.com>

msherif1234 added a commit to msherif1234/network-observability-operator that referenced this pull request Jul 17, 2023

NETOBSERV-1190: use DNS latency instead of TS

97cd9d0

This PR depends on PR netobserv#331 so 331 need to be merged 1st Signed-off-by: msherif1234 <mmahmoud@redhat.com>

msherif1234 closed this Jul 17, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NETOBSERV-1062: Add TCP drop and DNS tracking to netobserv operator #331

NETOBSERV-1062: Add TCP drop and DNS tracking to netobserv operator #331

msherif1234 commented Apr 28, 2023 •

edited

openshift-ci-robot commented Apr 28, 2023 •

edited by openshift-ci bot

openshift-ci-robot commented Apr 28, 2023 •

edited by openshift-ci bot

codecov bot commented Apr 28, 2023 •

edited

msherif1234 commented Apr 29, 2023

github-actions bot commented Apr 29, 2023

msherif1234 commented Apr 29, 2023

github-actions bot commented Apr 29, 2023

msherif1234 commented May 1, 2023

github-actions bot commented May 1, 2023

jpinsonneau commented May 2, 2023

msherif1234 commented May 2, 2023

github-actions bot commented May 2, 2023

memodi commented Jul 13, 2023 •

edited

msherif1234 commented Jul 13, 2023

github-actions bot commented Jul 13, 2023

msherif1234 commented Jul 14, 2023

github-actions bot commented Jul 14, 2023

msherif1234 commented Jul 14, 2023

github-actions bot commented Jul 14, 2023

msherif1234 commented Jul 14, 2023

github-actions bot commented Jul 14, 2023

jotak commented Jul 17, 2023

msherif1234 commented Jul 17, 2023

NETOBSERV-1062: Add TCP drop and DNS tracking to netobserv operator #331

NETOBSERV-1062: Add TCP drop and DNS tracking to netobserv operator #331

Conversation

msherif1234 commented Apr 28, 2023 • edited

openshift-ci-robot commented Apr 28, 2023 • edited by openshift-ci bot

openshift-ci-robot commented Apr 28, 2023 • edited by openshift-ci bot

codecov bot commented Apr 28, 2023 • edited

Codecov Report

msherif1234 commented Apr 29, 2023

github-actions bot commented Apr 29, 2023

msherif1234 commented Apr 29, 2023

github-actions bot commented Apr 29, 2023

msherif1234 commented May 1, 2023

github-actions bot commented May 1, 2023

jpinsonneau commented May 2, 2023

msherif1234 commented May 2, 2023

github-actions bot commented May 2, 2023

memodi commented Jul 13, 2023 • edited

msherif1234 commented Jul 13, 2023

github-actions bot commented Jul 13, 2023

msherif1234 commented Jul 14, 2023

github-actions bot commented Jul 14, 2023

msherif1234 commented Jul 14, 2023

github-actions bot commented Jul 14, 2023

msherif1234 commented Jul 14, 2023

github-actions bot commented Jul 14, 2023

jotak commented Jul 17, 2023

msherif1234 commented Jul 17, 2023

msherif1234 commented Apr 28, 2023 •

edited

openshift-ci-robot commented Apr 28, 2023 •

edited by openshift-ci bot

openshift-ci-robot commented Apr 28, 2023 •

edited by openshift-ci bot

codecov bot commented Apr 28, 2023 •

edited

memodi commented Jul 13, 2023 •

edited