Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1050 & NETOBSERV-1065 Transport field in IPFIX exporter not working #351

Merged
merged 2 commits into from
Jun 7, 2023

Conversation

jpinsonneau
Copy link
Contributor

@jpinsonneau jpinsonneau commented May 26, 2023

It seems FLP manages only lowercase for IPFIX export Transport field.

I have created a getIPFIXTransport function to convert values from CR to FLP values.
Empty values will fallback on "tcp"

@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #351 (d0b357c) into main (d623e5b) will increase coverage by 0.01%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##             main     #351      +/-   ##
==========================================
+ Coverage   51.42%   51.44%   +0.01%     
==========================================
  Files          43       43              
  Lines        5186     5192       +6     
==========================================
+ Hits         2667     2671       +4     
- Misses       2323     2325       +2     
  Partials      196      196              
Flag Coverage Δ
unittests 51.44% <71.42%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controllers/flowlogspipeline/flp_common_objects.go 85.62% <71.42%> (-0.19%) ⬇️

@jpinsonneau jpinsonneau changed the title NETOBSERV-1050 Transport field in IPFIX exporter not working NETOBSERV-1050 & NETOBSERV-1065 Transport field in IPFIX exporter not working May 26, 2023
@msherif1234
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label May 26, 2023
@github-actions
Copy link

New images:

  • quay.io/netobserv/network-observability-operator:d4f8c57
  • quay.io/netobserv/network-observability-operator-bundle:v0.0.0-d4f8c57
  • quay.io/netobserv/network-observability-operator-catalog:v0.0.0-d4f8c57

They will expire after two weeks.

Catalog source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-d4f8c57
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

@jpinsonneau jpinsonneau requested a review from jotak May 30, 2023 08:15
@jotak
Copy link
Member

jotak commented May 30, 2023

/lgtm
(not tested)

@Amoghrd
Copy link
Contributor

Amoghrd commented Jun 1, 2023

/ok-to-test

@Amoghrd
Copy link
Contributor

Amoghrd commented Jun 7, 2023

/label qe-approved

@jpinsonneau
Copy link
Contributor Author

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jun 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpinsonneau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jun 7, 2023
@openshift-merge-robot openshift-merge-robot merged commit 1183794 into netobserv:main Jun 7, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. qe-approved QE has approved this pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants