Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NETOBSERV-764: Loki v1beta2 model follow-up #474

Merged
merged 6 commits into from
Nov 1, 2023
Merged

NETOBSERV-764: Loki v1beta2 model follow-up #474

merged 6 commits into from
Nov 1, 2023

Commits on Oct 31, 2023

  1. Loki v1beta2 model follow-up 

    API changes:
- Improve default values in monolithic and microservices modes to stick
  with our guides (e.g. http://loki-distributor:3100/ as the ingester
URL)
- Rename modes so that they match upstream Loki naming
- In microservices mode, the querier URL isn't optional
- Add ability to configure tenant in these modes
- Add documentation in places where it was missing; fix some typos
- Strong-type LokiMode; set the enum a CamelCase as this is recommended;
  set it as a unionDiscriminator

Implementation changes:
- Use a "Hub" struct to convert any Loki mode into something alike Manual
  config; this avoids having to define many getter helpers each doing a
switch/case.
- Adapt some tests to better cover nominal use case, e.g.
certificates_test now uses LokiStack mode
    @jotak
    jotak committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    2018e03 View commit details
    Browse the repository at this point in the history

  2. fix double backticks

    @jotak
    jotak committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    08da2c2 View commit details
    Browse the repository at this point in the history

  3. Automatically deploy roles for Loki when using LokiStack

    @jotak
    jotak committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    871680e View commit details
    Browse the repository at this point in the history

  4. Add tests, new loki package

    @jotak
    jotak committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    49273cc View commit details
    Browse the repository at this point in the history

  5. download and pin yq

    @jotak
    jotak committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    59d09e5 View commit details
    Browse the repository at this point in the history

  6. Remove lokistack sample ; lokistack mentioned in main sample

    @jotak
    jotak committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    b136d06 View commit details
    Browse the repository at this point in the history