Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1017: pods/services bandwidth (flowmetrics / dev preview) #523

Merged
merged 1 commit into from Jan 18, 2024

Conversation

jotak
Copy link
Member

@jotak jotak commented Jan 12, 2024

Description

Provide sample FlowMetrics files to get top pods/services bandwidth The metrics can be queried with:

  • Pods incoming: topk(10, sum(rate(netobserv_pod_incoming_bytes_total[1m])) by (DstK8S_Name, DstK8S_Namespace))
  • Pods outgoing: topk(10, sum(rate(netobserv_pod_outgoing_bytes_total[1m])) by (SrcK8S_Name, SrcK8S_Namespace))
  • Services incoming: topk(10, sum(rate(netobserv_service_incoming_bytes_total[1m])) by (DstK8S_Name, DstK8S_Namespace))

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Provide sample FlowMetrics files to get top pods/services bandwidth
The metrics can be queried with:

- Pods incoming: topk(10, sum(rate(netobserv_pod_incoming_bytes_total[1m])) by (DstK8S_Name, DstK8S_Namespace))
- Pods outgoing: topk(10, sum(rate(netobserv_pod_outgoing_bytes_total[1m])) by (SrcK8S_Name, SrcK8S_Namespace))
- Services incoming: topk(10, sum(rate(netobserv_service_incoming_bytes_total[1m])) by (DstK8S_Name, DstK8S_Namespace))
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jan 12, 2024

@jotak: This pull request references NETOBSERV-1017 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Description

Provide sample FlowMetrics files to get top pods/services bandwidth The metrics can be queried with:

  • Pods incoming: topk(10, sum(rate(netobserv_pod_incoming_bytes_total[1m])) by (DstK8S_Name, DstK8S_Namespace))
  • Pods outgoing: topk(10, sum(rate(netobserv_pod_outgoing_bytes_total[1m])) by (SrcK8S_Name, SrcK8S_Namespace))
  • Services incoming: topk(10, sum(rate(netobserv_service_incoming_bytes_total[1m])) by (DstK8S_Name, DstK8S_Namespace))

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
  • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jotak jotak added no-qe This PR doesn't necessitate QE approval no-doc This PR doesn't require documentation change on the NetObserv operator labels Jan 12, 2024
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ca912f6) 56.23% compared to head (3e637d1) 56.56%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #523      +/-   ##
==========================================
+ Coverage   56.23%   56.56%   +0.33%     
==========================================
  Files          69       69              
  Lines        9084     9084              
==========================================
+ Hits         5108     5138      +30     
+ Misses       3647     3624      -23     
+ Partials      329      322       -7     
Flag Coverage Δ
unittests 56.56% <ø> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@OlivierCazade OlivierCazade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jotak
Copy link
Member Author

jotak commented Jan 18, 2024

/approve

Copy link

openshift-ci bot commented Jan 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak, OlivierCazade

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [OlivierCazade,jotak]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jotak jotak merged commit da4bdd3 into netobserv:main Jan 18, 2024
11 checks passed
@jotak jotak deleted the per-pod-service branch February 8, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved jira/valid-reference lgtm no-doc This PR doesn't require documentation change on the NetObserv operator no-qe This PR doesn't necessitate QE approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants