Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1458: reduce loki streams, index FlowInfra #555

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

jotak
Copy link
Member

@jotak jotak commented Feb 1, 2024

This is drastically reducing the number of streams while keeping query performances almost identical
cf details in #554 (comment)

to be backported in 1.5

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Feb 1, 2024

@jotak: This pull request references NETOBSERV-1458 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

This is drastically reducing the number of streams while keeping query performances almost identical
cf details in #554 (comment)

to be backported in 1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jotak
Copy link
Member Author

jotak commented Feb 1, 2024

/test e2e-operator

@jotak
Copy link
Member Author

jotak commented Feb 1, 2024

/retest

@jotak
Copy link
Member Author

jotak commented Feb 2, 2024

/retest

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (12d6378) 57.79% compared to head (94a337d) 57.93%.
Report is 1 commits behind head on main.

Files Patch % Lines
controllers/flowcollector_controller.go 72.72% 1 Missing and 2 partials ⚠️
controllers/flp/flp_controller.go 70.00% 1 Missing and 2 partials ⚠️
controllers/monitoring/monitoring_controller.go 70.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #555      +/-   ##
==========================================
+ Coverage   57.79%   57.93%   +0.14%     
==========================================
  Files          72       73       +1     
  Lines        9532     9543      +11     
==========================================
+ Hits         5509     5529      +20     
+ Misses       3686     3680       -6     
+ Partials      337      334       -3     
Flag Coverage Δ
unittests 57.93% <75.67%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nathan-weinberg
Copy link
Contributor

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved QE has approved this pull request label Feb 2, 2024
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Feb 2, 2024

@jotak: This pull request references NETOBSERV-1458 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

This is drastically reducing the number of streams while keeping query performances almost identical
cf details in #554 (comment)

to be backported in 1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jotak
Copy link
Member Author

jotak commented Feb 2, 2024

/approve

Copy link

openshift-ci bot commented Feb 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Feb 2, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 5d91297 into netobserv:main Feb 2, 2024
13 checks passed
@jotak jotak deleted the index-infra-main branch February 8, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants