Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1470: Reduce memory usage in agent due to kafka batches #567

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

jotak
Copy link
Member

@jotak jotak commented Feb 13, 2024

As shown here in run11, this tuning drastically reduces memory used due to kafka batching, retrieving similar level than in 1.4 (even slightly better).

It should be verified on large-scale perf tests

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Feb 13, 2024

@jotak: This pull request references NETOBSERV-1470 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

As shown here in run11, this tuning drastically reduces memory used due to kafka batching, retrieving similar level than in 1.4 (even slightly better).

It should be verified on large-scale perf tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented Feb 13, 2024

@jotak: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-operator 6ce66b9 link false /test e2e-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jotak
Copy link
Member Author

jotak commented Feb 14, 2024

/approve

Copy link

openshift-ci bot commented Feb 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 142acc3 into netobserv:main Feb 14, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants