NETOBSERV-1427 Added support to FLP dynamic configmap #610
Conversation
go.mod
Outdated
| @@ -85,3 +85,5 @@ require ( | |||
| ) | |||
|
|
|||
| replace github.com/prometheus/common v0.48.0 => github.com/netobserv/prometheus-common v0.48.0-netobserv | |||
|
|
|||
| replace github.com/netobserv/flowlogs-pipeline v0.1.12-0.20240322124726-d2b2352bfe0f => github.com/OlivierCazade/flowlogs-pipeline v0.0.2-0.20240325155329-387a8ce37ceb | |||
There was a problem hiding this comment.
TODO: change this once the FLP PR is merged
|
/hold |
OlivierCazade
force-pushed
the
1427
branch
2 times, most recently
from
15e3920
to
96b5885
Compare
OlivierCazade
force-pushed
the
1427
branch
2 times, most recently
from
e301cab
to
628edd0
Compare
| hasher := fnv.New64a() | ||
| _, _ = hasher.Write([]byte(configStr)) | ||
| digest := strconv.FormatUint(hasher.Sum64(), 36) | ||
| return &configMap, digest, nil | ||
| } |
There was a problem hiding this comment.
if I'm correct, the digest here isn't used, as digests are used to restart pods, and in the case of dynamic config we precisely don't want to restart pods?
If it's not used anywhere I'd rather not generate it, also to not bring confusion about how the reconciliation works
There was a problem hiding this comment.
Fixed, thanks.
|
thanks @OlivierCazade |
|
@OlivierCazade: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@OlivierCazade this PR has DNM label, is it ready for pre-merge testing? |
|
@memodi Right now the PR FLP dependency is pointing to the associated PR dev branch. This PR is ready for testing but before merging we need to merge FLP PR first and then update the dependency to point to FLP main branch. |
|
/label qe-approved |
|
New changes are detected. LGTM label has been removed. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: OlivierCazade The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 216e3e6
into
netobserv:main
Description
Added support to FLP dynamic configmap
Dependencies
FLP PR
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.