NETOBSERV-1647: Do not load loki cert when loki disabled [Backport 1.6] #670
Conversation
|
@jotak: This pull request references NETOBSERV-1647 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-1.6 #670 +/- ##
============================================
Coverage 66.58% 66.59%
============================================
Files 70 70
Lines 8108 8110 +2
============================================
+ Hits 5399 5401 +2
Misses 2315 2315
Partials 394 394
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
|
New images:
They will expire after two weeks. To deploy this build: # Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:9f7c731 make deploy
# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-9f7c731Or as a Catalog Source: apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
name: netobserv-dev
namespace: openshift-marketplace
spec:
sourceType: grpc
image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-9f7c731
displayName: NetObserv development catalog
publisher: Me
updateStrategy:
registryPoll:
interval: 1m |
|
this fixes it, thanks! /label qe-approved |
|
@jotak: This pull request references NETOBSERV-1647 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Note we're talking here about versions of ConversionReview (ie. apiextension), NOT versions of our CRDs - Use same versions for flowcollector and flowmetrics - Use just v1 as the only other (v1beta1) was dropped a while ago (kube 1.22 / 2021)
github-actions
bot
removed
the
ok-to-test
|
@jotak: This pull request references NETOBSERV-1647 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 8c0c1eb
into
netobserv:release-1.6
cf #669
also includes backport of #662 to fix flaky CI