Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nls: Mark more strings and add translations #193

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

andy5995
Copy link
Member

No description provided.

@andy5995 andy5995 requested a review from ph2708 January 28, 2024 09:43
"PO-Revision-Date: 2024-01-24 16:12-0600\n"
"Last-Translator: none <no-one@nowhere.net>\n"
"Last-Translator: ChatGPT\n"
"Language: pt_BR\n"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ph2708 What do you think of ChatGPT's translations?

@andy5995
Copy link
Member Author

image

@andy5995
Copy link
Member Author

I suppose there's no point to this until the layout is changed to account for the variable width of the translated strings.

@andy5995 andy5995 closed this Jan 29, 2024
@andy5995 andy5995 deleted the mark-strings branch January 29, 2024 21:02
@winrid
Copy link
Member

winrid commented Jan 29, 2024

@andy5995 you can keep this open! I think supporting variable length strings is something to support sooner rather than later.

We should just continue to improve the existing UI system for now to unblock improvements, until someone has time to support an alternative. I did not find a nice alternative yet.

Supporting variable length strings is relatively trivial in complexity, however it is a lot of grunt work... :) I migrated a lot of the UI already - just have to call the appropriate Surface::getStringWidth/Height when creating your surface. At some point we should have a "TextSurface" that auto sets up its width and supports line wrapping - maybe that is something that can be done sooner or later.

@andy5995
Copy link
Member Author

Ok, I'll have to recreate the branch

@andy5995 andy5995 restored the mark-strings branch January 29, 2024 21:17
@andy5995
Copy link
Member Author

Oh, a button to restore...

@andy5995 andy5995 reopened this Jan 29, 2024
@winrid
Copy link
Member

winrid commented Feb 11, 2024

Progress to unblock this here: #214

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants