meson: Make more modular #211
Conversation
| paktool = ['bmp2pak', 'pak2bmp'] | ||
|
|
||
| foreach tool : paktool | ||
| executable( | ||
| tool, | ||
| tool + '.cpp', | ||
| win_subsystem: 'console', | ||
| dependencies: (platform_is_windows ? netpanzer_dep_static : netpanzer_dep_shared), | ||
| dependencies: paktool_deps, |
There was a problem hiding this comment.
@winrid Note here especially: we're no longer linking to the entire netpanzer library, but only to a few individual dependencies.
A small advantage in this case, but maybe more useful in the long-term.
There was a problem hiding this comment.
Actually I remember I noticed in the scons build there was linking to individual objects like that.
andy5995
force-pushed
the
make-modular
branch
3 times, most recently
from
891651c
to
08dcc2d
Compare
I hope it works out ok. The new libraries I created depend on other things... they're not "isolated" libraries for lack of a better term. Right now this is building on all platforms but Windows. https://github.com/netpanzer/netpanzer/actions/runs/7872860492/job/21478990447?pr=211 |
|
Now the Windows build fails with a different undef error, and one of the tests on all macos builds fails. |
Making things more modular will probably make keeping track of things, and tracking down problems, and keeping track of what depends on what - easier in the long run.
andy5995
force-pushed
the
make-modular
branch
from
11e0527
to
1fcccf3
Compare
Making things more modular will probably make keeping track of things, and tracking down problems, and keeping track of what depends on what - easier in the long run.