Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve Equatable and Hashable conformance #148

Merged
merged 5 commits into from
Jan 14, 2024
Merged

Conversation

cbaker6
Copy link
Member

@cbaker6 cbaker6 commented Jan 14, 2024

New Pull Request Checklist

Issue Description

Approach

TODOs before merging

  • Add tests
  • Add entry to changelog

Copy link

codecov bot commented Jan 14, 2024

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (dc037bd) 91.75% compared to head (189687d) 91.81%.

Files Patch % Lines
...rces/ParseSwift/LiveQuery/LiveQueryConstants.swift 0.00% 5 Missing ⚠️
Sources/ParseSwift/LiveQuery/ParseLiveQuery.swift 50.00% 2 Missing ⚠️
Sources/ParseSwift/Protocols/Objectable.swift 66.66% 2 Missing ⚠️
Sources/ParseSwift/Extensions/Encodable.swift 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #148      +/-   ##
==========================================
+ Coverage   91.75%   91.81%   +0.05%     
==========================================
  Files         178      178              
  Lines       15715    15800      +85     
==========================================
+ Hits        14419    14506      +87     
+ Misses       1296     1294       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cbaker6 cbaker6 merged commit b3169f2 into main Jan 14, 2024
14 checks passed
@cbaker6 cbaker6 deleted the improveObjectHasher branch January 14, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant