feat: Add user login related attempts to ParseCloudUser #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #51 +/- ##
==========================================
- Coverage 90.44% 90.41% -0.03%
==========================================
Files 163 163
Lines 16492 16492
==========================================
- Hits 14916 14912 -4
- Misses 1576 1580 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -15,4 +15,9 @@ | |||
| public protocol ParseCloudUser: ParseUser { | |||
| /// The session token of the `ParseUser`. | |||
| var sessionToken: String? { get set } | |||
| /// The number of unsuccessful login attempts. | |||
| var _failed_login_count: Int? { get } | |||
Check warning
Code scanning / Tailor (reported by Codacy)
Variable names should be lowerCamelCase
| var _failed_login_count: Int? { get } | ||
| /// The date the lockout expires. After this date, the `ParseUser` | ||
| /// can attempt to login again. | ||
| var _account_lockout_expires_at: Date? { get } |
Check warning
Code scanning / Tailor (reported by Codacy)
Variable names should be lowerCamelCase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
Issue Description
ParseCloudUseris missing properties:_failed_login_countand_account_lockout_expires_at. These these can be added to a conforming type directly by the developer, adding them to theParseCloudUsercan ensure they are used correctly.Approach
Add
_failed_login_countand_account_lockout_expires_attoParseCloudUseras getters only, preventing them from being set from Cloud Code. The Parse Server has routes and checks to increment/delete these properties at the necessary time. In Cloud Code, the developer may need to read these values to make a decision.Though these properties are not written in a Swifty way (they are not lowerCamelCase) they are left as-is to prevent writing encoding keys for
ParseCloudUseras this is how they look on the Parse Server.TODOs before merging