Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Switch mounting point for Playgrounds #52

Merged
merged 4 commits into from
Jan 24, 2023
Merged

Conversation

cbaker6
Copy link
Member

@cbaker6 cbaker6 commented Jan 24, 2023

New Pull Request Checklist

Issue Description

The mounting point for playgrounds works more consistently when it's a String instead of an Int.

Approach

  • Change the Playground mount from /1 to /parse
  • Sometimes a ParseFile doesn't sent url. Make decoding url optional
  • Decode the functionName and triggerName when receiving Parse Hook requests.

TODOs before merging

  • Add tests
  • Add entry to changelog
  • Add changes to documentation (guides, repository pages, in-code descriptions)

@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Merging #52 (2f579f3) into main (cbfed65) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
+ Coverage   90.41%   90.44%   +0.02%     
==========================================
  Files         163      163              
  Lines       16492    16492              
==========================================
+ Hits        14912    14916       +4     
+ Misses       1580     1576       -4     
Impacted Files Coverage Δ
...es/ParseSwift/Types/ParseHookFunctionRequest.swift 100.00% <ø> (ø)
...ces/ParseSwift/Types/ParseHookTriggerRequest.swift 100.00% <ø> (ø)
Sources/ParseSwift/Types/ParseFile.swift 95.45% <100.00%> (ø)
Sources/ParseSwift/Objects/ParseObject+async.swift 96.29% <0.00%> (-0.38%) ⬇️
Sources/ParseSwift/Coding/ParseEncoder.swift 78.14% <0.00%> (+0.11%) ⬆️
Sources/ParseSwift/LiveQuery/ParseLiveQuery.swift 75.11% <0.00%> (+0.58%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cbaker6 cbaker6 merged commit de696cc into main Jan 24, 2023
@cbaker6 cbaker6 deleted the playgrounds branch January 24, 2023 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant