Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make it easier to login with email or authData #67

Merged
merged 1 commit into from
Mar 10, 2023
Merged

Conversation

cbaker6
Copy link
Member

@cbaker6 cbaker6 commented Mar 10, 2023

New Pull Request Checklist

Issue Description

The login method currently doesn't except a password or authData. The workaround is to create an instance of ParseUser and add any properties.

Approach

Add email and authData as optional parameters. Make the already provided parameter, username optional.

TODOs before merging

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)

@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Merging #67 (3351c7b) into main (62eee27) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
- Coverage   90.47%   90.46%   -0.02%     
==========================================
  Files         166      166              
  Lines       14952    14955       +3     
==========================================
+ Hits        13528    13529       +1     
- Misses       1424     1426       +2     
Impacted Files Coverage Δ
Sources/ParseSwift/Objects/ParseUser+async.swift 94.28% <100.00%> (+0.04%) ⬆️
Sources/ParseSwift/Objects/ParseUser+combine.swift 95.91% <100.00%> (+0.05%) ⬆️
Sources/ParseSwift/Objects/ParseUser.swift 90.78% <100.00%> (-0.02%) ⬇️

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cbaker6 cbaker6 merged commit 11bb8e6 into main Mar 10, 2023
@cbaker6 cbaker6 deleted the emailLogin branch March 10, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant