-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add the ability to access ParseConfig as a dictionary #68
Conversation
options: options, | ||
completion: promise) | ||
} | ||
} |
Check warning
Code scanning / Tailor (reported by Codacy)
Function should have at least one blank line after it
- note: The default cache policy for this method is `.reloadIgnoringLocalCacheData`. If a developer | ||
desires a different policy, it should be inserted in `options`. | ||
*/ | ||
static func fetch(options: API.Options = []) async throws -> [String: V] { |
Check warning
Code scanning / Tailor (reported by Codacy)
Function should have at least one blank line after it
- throws: An error of type `ParseError`. | ||
*/ | ||
static func save(_ config: [String: V], | ||
options: API.Options = []) async throws -> Bool { |
Check warning
Code scanning / Tailor (reported by Codacy)
Function should have at least one blank line after it
@@ -407,7 +407,7 @@ | |||
return modifiedACL | |||
} | |||
|
|||
internal static func deleteDefaultFromKeychain() async { | |||
internal static func deleteDefaultFromStorage() async { |
Check warning
Code scanning / Tailor (reported by Codacy)
Function should have at least one blank line after it
Codecov Report
@@ Coverage Diff @@
## main #68 +/- ##
==========================================
- Coverage 90.49% 87.65% -2.84%
==========================================
Files 166 128 -38
Lines 14955 12439 -2516
==========================================
- Hits 13533 10903 -2630
- Misses 1422 1536 +114
... and 57 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
New Pull Request Checklist
Issue Description
Addresses feature ask in #57.
Approach
Add a new type called
ParseConfigCodable
which is interoperable with any type that conforms toParseConfig
. That means that either can be used to save/fetch the Config either from the Server or from local storage (Memory/Keychain). Below is an example of how to use the newParseConfigCodable
with a type erased AnyCodable values. Note that anyCodable
type can be used for the value of the Dictionary. The keys will always be strings:TODOs before merging