Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Address Swift 5.8 warnings #90

Merged
merged 20 commits into from
Apr 4, 2023
Merged

refactor: Address Swift 5.8 warnings #90

merged 20 commits into from
Apr 4, 2023

Conversation

cbaker6
Copy link
Member

@cbaker6 cbaker6 commented Apr 3, 2023

New Pull Request Checklist

Issue Description

Xcode 14.3 and Swift 5.8 introduced a number of new warnings when building the project.

Approach

Remove all warnings and use new await fulfillment(of: [expectation1], timeout: 20.0) instead of wait(for: [expectation1], timeout: 20.0) for async tests as there's a known deadlock issue with XCTestCase.wait in Xcode <=14.2. See 14.3 changelog for reference.

TODOs before merging

  • Add tests
  • Add entry to changelog

@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Merging #90 (b806145) into main (a790bb7) will increase coverage by 0.43%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
+ Coverage   90.95%   91.38%   +0.43%     
==========================================
  Files         172      172              
  Lines       15209    15261      +52     
==========================================
+ Hits        13834    13947     +113     
+ Misses       1375     1314      -61     
Impacted Files Coverage Δ
Sources/ParseSwift/Storage/KeychainStore.swift 93.71% <100.00%> (+0.83%) ⬆️
Sources/ParseSwift/Storage/ParseFileManager.swift 92.51% <100.00%> (-0.31%) ⬇️

... and 9 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cbaker6 cbaker6 merged commit 088e420 into main Apr 4, 2023
@cbaker6 cbaker6 deleted the depr branch April 4, 2023 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant