Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Existing Hooks are replaced with new ones on restart #33

Merged
merged 4 commits into from
May 28, 2023
Merged

Conversation

cbaker6
Copy link
Member

@cbaker6 cbaker6 commented May 28, 2023

  • When ParseServerSwift starts, it will 1) detect if a hook already exists on a node ParseServer, 2) delete the current hook 3) create a new hook. This prevents the node ParseServer from accidentally using a stale hook and polluting the Dashboard with multiple versions of the same hook

@codecov
Copy link

codecov bot commented May 28, 2023

Codecov Report

Merging #33 (fa7a4ea) into main (7276ce7) will decrease coverage by 1.21%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
- Coverage   49.15%   47.95%   -1.21%     
==========================================
  Files          11       11              
  Lines         714      732      +18     
==========================================
  Hits          351      351              
- Misses        363      381      +18     
Impacted Files Coverage Δ
Sources/ParseServerSwift/Models/HookFunction.swift 39.66% <0.00%> (-2.81%) ⬇️
Sources/ParseServerSwift/Models/HookTrigger.swift 38.76% <0.00%> (-2.31%) ⬇️

@cbaker6 cbaker6 changed the title fix: Hooks should attempt to update if already exists fix: Existing Hooks are replaced with new ones on restart May 28, 2023
@cbaker6 cbaker6 merged commit fbd814b into main May 28, 2023
5 of 6 checks passed
@cbaker6 cbaker6 deleted the updateHook branch May 28, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant