Updated patch exec location check to attempt fallback to global "patch" #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CybotTM
reviewed
Nov 24, 2020
| throw new Exception("Cannot find the 'patch' executable command - use your o/s package manager like 'sudo yum install patch'"); | ||
| // See if patch is in path. | ||
| $exitCode = $output = null; | ||
| exec('patch -v', $output, $exitCode); |
There was a problem hiding this comment.
Why don't you replace which patch with patch -v in the first place?
There was a problem hiding this comment.
looks like he had the same problem as me, the current code with which does not work on windows (at least it fails on my windows system). my patch is inside the path so it would work otherwise.
|
Closing due to being outdated/abandoned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes it failing on windows if patch is actually available in the
PATH