Apparently you cant really do GETs with Pages. Fixed up Contribution …

…to deal with summary view on get.
netroots · Feb 17, 2009 · c8c60cb · c8c60cb
1 parent 8f7d5f9
commit c8c60cb
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 14 deletions.
diff --git a/lib/actblue/contribution.rb b/lib/actblue/contribution.rb
@@ -4,10 +4,14 @@ class Contribution < ActiveBlue
 
     XML_NAME = 'contribution'
     ATTRIBUTES = ['order-number', 'created-on']
-    ELEMENTS = ['refcode', 'source', 'timestamp', 'submitter', 'recurring', 'recurringtimes', 'referrer', 'successuri', 'lineitems']
+    ELEMENTS = ['page', 'refcode', 'source', 'timestamp', 'submitter', 'recurring', 'recurringtimes', 'referrer', 'successuri', 'lineitems']
 
     def self.get(params)
       hash = ActiveBlue.get('/contributions', :query => params)
+      unless hash
+        return nil
+      end
+      return hash["contributions"] if ((params["view"] == "summary") || (params[:view] == "summary"))
       result = []
       if hash["contributions"]
         hash["contributions"]["contribution"].each do |h|

diff --git a/lib/actblue/page.rb b/lib/actblue/page.rb
@@ -6,19 +6,6 @@ class Page < ActiveBlue
     ATTRIBUTES =  ['name', 'partner', 'created-on']
     ELEMENTS =    ['title', 'author', 'blurb', 'visibility', 'showcandidatesummary', 'listentries']
 
-    def self.get(params)
-      hash = ActiveBlue.get('/pages', :query => params)
-      result = []
-      if hash["pages"]
-        hash["pages"].each do |h|
-          result << Page.new(h)
-        end
-      elsif hash["page"]
-        result << Page.new(hash["page"])
-      end
-      result
-    end
-
     def post
       super.post('/pages', :body => to_xml)
     end