Add buffer support for TIFF images. #46
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supports buffer of TIFF image. Removed memory overhead.
Update tiff.js
Update tiff.js
| if (type !== 'tiff') { | ||
| expect(bufferDimensions.width).to.be(expected.width); | ||
| expect(bufferDimensions.height).to.be(expected.height); | ||
| } |
There was a problem hiding this comment.
The only thing that should be changed in this file should be the removal of if (type !== 'tiff'), otherwise you're removing buffer testing altogether?
|
I have made a comment that hasn't been resolved yet... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TIFF images can be in buffers not only in files.