Support all JPGs rather than specific JFIF ones #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the purposes of this library requiring JPEGs use the JFIF standard doesn't seem necessary. Old school non-JFIF jpegs, like the kind produced by ffmpeg, aren't usable as-is. Since there was only a limited set of markers in the list and a TODO to support all I've just removed the JFIF requirement entirely. JFIF will still work fine but now so will all valid JPEGs.
|
This also fixes issue #44. |
|
Obligatory +1 here - the JFIF combing seems entirely unnecessary given the many other possibilities. |
|
LGTM |
shinnn
added a commit
that referenced
this pull request
Nov 23, 2015
Support all JPGs rather than specific JFIF ones
This was referenced Nov 23, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the purposes of this library requiring JPEGs use the JFIF standard doesn't seem necessary. Old school non-JFIF jpegs, like the kind produced by ffmpeg, aren't usable as-is.
Since there was only a limited set of markers in the list and a TODO to support all I've just removed the JFIF requirement entirely. JFIF will still work fine but now so will all valid JPEGs.