Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST]: Register modules within action_groups #307

Closed
fa-elepape opened this issue Nov 15, 2023 · 2 comments
Closed

[FEATURE REQUEST]: Register modules within action_groups #307

fa-elepape opened this issue Nov 15, 2023 · 2 comments
Assignees

Comments

@fa-elepape
Copy link

Summary

All (I think) modules within the collection use the same parameters when determining how and where to address the NetScaler instance:

  • api_path
  • nitro_auth_token
  • nitro_pass
  • nitro_protocol
  • nitro_user
  • nsip
  • save_config
  • validate_certs

Given the wide range of modules available, module_defaults is hardly usable, and specifying parameters everywhere is tiresome which makes environment variables the only viable solution (IMO). Registering the modules within an action group would make using module_defaults far easier.

Action groups aren't documented within the Collection Galaxy metadata structure documentation but within the Module defaults.

Issue Type

Feature Idea

Component Name

Describe alternatives you've considered

The environment variable works just fine, this Feature Request is an enhancement, not a blocker.

Additional Information

- name: NetScaler playbook
  module_defaults:
    groups/netscaler.adc.config:
      api_path: /prefix
      nitro_auth_token: !vault |
        ...
      nitro_user: me
      nsip: netscaler.example.com
      save_config: true
      validate_certs: true

  tasks:
  - netscaler.adc.server:
      domain: example.com
      name: example.com
  - netscaler.adc.servicegroup:
      servicegroupname: example.com
      servicetype: SSL
  - netscaler.adc.sslprofile:
      name: example
      ocspstapling: 'ENABLED'
@sumanth-lingappa
Copy link
Collaborator

Thank you for this enhancement-request. This is very much needed. I was exploring this as well.

sumanth-lingappa added a commit that referenced this issue Jan 7, 2024
…t-arg

Issue: #307 added module_defaults action groups
@sumanth-lingappa
Copy link
Collaborator

Thank you for this enhancement @fa-elepape. I have added this functionality. Please expect this in the next release.

However, you can also download the unreleased latest netscaler.adc ansible collection directly from github

ansible-galaxy collection install "git+https://github.com/netscaler/ansible-collection-netscaleradc.git" --force

Refer https://github.com/netscaler/ansible-collection-netscaleradc?tab=readme-ov-file#via-github-to-have-the-latest-updated-which-are-yet-to-be-released-in-ansible-galaxy for more details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants