[webapp] Add Multi-Path Colors & bug fixes #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds deterministic colors for each unique path. - Adds path colors to path selection list. - Adds/changes path colors to bwtest and echo graph data points. - Adds path # hops as a badge next to path selection list. - Adds gray color for graph data points without matching paths. - Changes to faint-red color for graph error data points, not red. - Fixes bwtest failure to match interactive paths due to ANSI escapes. - Fixes bwtest failure to match default path. - Improves regex cases to record echo errors. - Adds stderr to command parsing stream with stdout. - Fixes overlapping continuous switch conditions between user-server. - Fixes netsec-ethz#69.
|
|
chaehni
approved these changes
Jul 1, 2019
There was a problem hiding this comment.
A really cool addition to the webapp!
One minor point: When apps are missing (it seems we don't install them automatically anymore) there is no error shown on the frontend when a continuous test is started. For a single run, there is an error message.
Reviewed 7 of 8 files at r1, 1 of 1 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
mwfarb
added a commit
to mwfarb/scion-apps
that referenced
this pull request
Jul 1, 2019
This reverts commit 2b7ec0c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is