Container::getComponents() parameters are silently deprecated

nette · Feb 8, 2024 · bb838ad · bb838ad
1 parent 3dc759c
commit bb838ad
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/src/ComponentModel/Container.php b/src/ComponentModel/Container.php
@@ -178,12 +178,13 @@ protected function createComponent(string $name): ?IComponent
 
 
 	/**
-	 * Iterates over descendants components.
-	 * @return iterable<int|string,IComponent>
+	 * Returns immediate child components.
+	 * @return array<int|string,IComponent>
 	 */
-	final public function getComponents(bool $deep = false, ?string $filterType = null): iterable
+	final public function getComponents(): iterable
 	{
-		if ($deep) {
+		$filterType = func_get_args()[1] ?? null;
+		if (func_get_args()[0] ?? null) { // back compatibility
 			$iterator = new RecursiveComponentIterator($this->components);
 			$iterator = new \RecursiveIteratorIterator($iterator, \RecursiveIteratorIterator::SELF_FIRST);
 			if ($filterType) {

diff --git a/src/ComponentModel/IContainer.php b/src/ComponentModel/IContainer.php
@@ -35,8 +35,8 @@ function removeComponent(IComponent $component): void;
 	function getComponent(string $name): ?IComponent;
 
 	/**
-	 * Iterates over descendants components.
-	 * @return iterable<int|string,IComponent>
+	 * Returns immediate child components.
+	 * @return array<int|string,IComponent>
 	 */
 	function getComponents(): iterable;
 }