Fixed phpstan issues #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👎 for removing from allow_failure because it is big complication for me. |
|
As you wish, reverted |
|
Why is annotation $components confusing? |
|
There is also $components property with typehint |
|
Where? |
|
But it is a different private property. |
|
How is anyone supposed to understand that two properties with same name are not the same one? It's not possible to do without magic. |
|
The second one is shortcut for getComponents(), presented for back compatibility. And magic is well documented https://doc.nette.org/cs/3.0/smartobject |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPStan should not report any issues, so I removed it from allow_failure to prevent any new issues in future