Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResultSet: only format strings as floats #228

Merged
merged 1 commit into from Apr 15, 2019
Merged

ResultSet: only format strings as floats #228

merged 1 commit into from Apr 15, 2019

Conversation

@spaze
Copy link
Contributor

spaze commented Apr 15, 2019

Because with native prepared statements in MySQL, floats are returned as floats, not strings like with emulated prepares

  • bug fix? #227
  • BC break? no
  • doc PR: no

Fixes #227

src/Database/ResultSet.php Outdated Show resolved Hide resolved
Because with native prepared statements in MySQL, floats are returned as floats, not strings like with emulated prepares

Fixes #227
@spaze spaze changed the title ResultSet: cast floats to string ResultSet: only format strings as floats Apr 15, 2019
@dg

This comment has been minimized.

Copy link
Member

dg commented Apr 15, 2019

Thanks!

@dg dg merged commit a418e3f into nette:master Apr 15, 2019
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 86.55%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.