Skip to content

Commit

Permalink
constants are PascalCase
Browse files Browse the repository at this point in the history
  • Loading branch information
dg committed Dec 4, 2022
1 parent 9568c2f commit e004976
Show file tree
Hide file tree
Showing 13 changed files with 36 additions and 27 deletions.
9 changes: 6 additions & 3 deletions src/DI/Definitions/Reference.php
Expand Up @@ -19,7 +19,10 @@ final class Reference
{
use Nette\SmartObject;

public const SELF = 'self';
public const Self = 'self';

/** @deprecated use Reference::Self */
public const SELF = self::Self;

/** @var string */
private $value;
Expand Down Expand Up @@ -49,7 +52,7 @@ public function getValue(): string

public function isName(): bool
{
return strpos($this->value, '\\') === false && $this->value !== self::SELF;
return strpos($this->value, '\\') === false && $this->value !== self::Self;
}


Expand All @@ -61,6 +64,6 @@ public function isType(): bool

public function isSelf(): bool
{
return $this->value === self::SELF;
return $this->value === self::Self;
}
}
2 changes: 1 addition & 1 deletion src/DI/Definitions/ServiceDefinition.php
Expand Up @@ -182,7 +182,7 @@ public function complete(Nette\DI\Resolver $resolver): void
is_string($setup->getEntity())
&& strpbrk($setup->getEntity(), ':@?\\') === false
) { // auto-prepend @self
$setup = new Statement([new Reference(Reference::SELF), $setup->getEntity()], $setup->arguments);
$setup = new Statement([new Reference(Reference::Self), $setup->getEntity()], $setup->arguments);
}

$setup = $resolver->completeStatement($setup, true);
Expand Down
9 changes: 6 additions & 3 deletions src/DI/DependencyChecker.php
Expand Up @@ -23,7 +23,10 @@ class DependencyChecker
{
use Nette\SmartObject;

public const VERSION = 1;
public const Version = 1;

/** @deprecated use DependencyChecker::Version */
public const VERSION = self::Version;

/** @var array of ReflectionClass|\ReflectionFunctionAbstract|string */
private $dependencies = [];
Expand Down Expand Up @@ -73,7 +76,7 @@ public function export(): array
$hash = self::calculateHash($classes, $functions);
$files = @array_map('filemtime', array_combine($files, $files)); // @ - file may not exist
$phpFiles = @array_map('filemtime', array_combine($phpFiles, $phpFiles)); // @ - file may not exist
return [self::VERSION, $files, $phpFiles, $classes, $functions, $hash];
return [self::Version, $files, $phpFiles, $classes, $functions, $hash];
}


Expand All @@ -93,7 +96,7 @@ public static function isExpired(
$currentFiles = @array_map('filemtime', array_combine($tmp = array_keys($files), $tmp)); // @ - files may not exist
$origPhpFiles = $phpFiles;
$phpFiles = @array_map('filemtime', array_combine($tmp = array_keys($phpFiles), $tmp)); // @ - files may not exist
return $version !== self::VERSION
return $version !== self::Version
|| $files !== $currentFiles
|| ($phpFiles !== $origPhpFiles && $hash !== self::calculateHash($classes, $functions));
} catch (\ReflectionException $e) {
Expand Down
2 changes: 1 addition & 1 deletion src/DI/Extensions/DecoratorExtension.php
Expand Up @@ -39,7 +39,7 @@ public function beforeCompile()
}

if ($info->inject !== null) {
$info->tags[InjectExtension::TAG_INJECT] = $info->inject;
$info->tags[InjectExtension::TagInject] = $info->inject;
}

$this->addSetups($type, Nette\DI\Helpers::filterArguments($info->setup));
Expand Down
7 changes: 5 additions & 2 deletions src/DI/Extensions/InjectExtension.php
Expand Up @@ -20,7 +20,10 @@
*/
final class InjectExtension extends DI\CompilerExtension
{
public const TAG_INJECT = 'nette.inject';
public const TagInject = 'nette.inject';

/** @deprecated use InjectExtension::TagInject */
public const TAG_INJECT = self::TagInject;


public function getConfigSchema(): Nette\Schema\Schema
Expand All @@ -32,7 +35,7 @@ public function getConfigSchema(): Nette\Schema\Schema
public function beforeCompile()
{
foreach ($this->getContainerBuilder()->getDefinitions() as $def) {
if ($def->getTag(self::TAG_INJECT)) {
if ($def->getTag(self::TagInject)) {
$def = $def instanceof Definitions\FactoryDefinition
? $def->getResultDefinition()
: $def;
Expand Down
4 changes: 2 additions & 2 deletions src/DI/Extensions/ServicesExtension.php
Expand Up @@ -113,7 +113,7 @@ private function updateServiceDefinition(Definitions\ServiceDefinition $definiti
}

if (isset($config->inject)) {
$definition->addTag(InjectExtension::TAG_INJECT, $config->inject);
$definition->addTag(InjectExtension::TagInject, $config->inject);
}
}

Expand Down Expand Up @@ -175,7 +175,7 @@ private function updateFactoryDefinition(Definitions\FactoryDefinition $definiti
}

if (isset($config->inject)) {
$definition->addTag(InjectExtension::TAG_INJECT, $config->inject);
$definition->addTag(InjectExtension::TagInject, $config->inject);
}
}

Expand Down
4 changes: 2 additions & 2 deletions src/DI/Resolver.php
Expand Up @@ -382,7 +382,7 @@ public function normalizeReference(Reference $ref): Reference
}

return $this->currentService && $service === $this->currentService->getName()
? new Reference(Reference::SELF)
? new Reference(Reference::Self)
: $ref;
}

Expand Down Expand Up @@ -414,7 +414,7 @@ public function getByType(string $type): Reference
&& $this->currentServiceAllowed
&& is_a($this->currentServiceType, $type, true)
) {
return new Reference(Reference::SELF);
return new Reference(Reference::Self);
}

$name = $this->builder->getByType($type, true);
Expand Down
8 changes: 4 additions & 4 deletions tests/DI/Compiler.dependencies.phpt
Expand Up @@ -17,7 +17,7 @@ $compiler = new DI\Compiler;

Assert::same(
[
DependencyChecker::VERSION,
DependencyChecker::Version,
[],
[],
[],
Expand All @@ -32,7 +32,7 @@ Assert::false(DependencyChecker::isExpired(...$compiler->exportDependencies()));
$compiler->addDependencies(['file1', __FILE__]);
Assert::same(
[
DependencyChecker::VERSION,
DependencyChecker::Version,
['file1' => false, __FILE__ => filemtime(__FILE__)],
[],
[],
Expand All @@ -47,7 +47,7 @@ Assert::false(DependencyChecker::isExpired(...$compiler->exportDependencies()));
$compiler->addDependencies(['file1', null, 'file3']);
Assert::same(
[
DependencyChecker::VERSION,
DependencyChecker::Version,
['file1' => false, __FILE__ => filemtime(__FILE__), 'file3' => false],
[],
[],
Expand All @@ -70,7 +70,7 @@ if (PHP_VERSION_ID >= 80100) {
$compiler->addDependencies([new ReflectionClass(Dep1::class)]);
Assert::same(
[
DependencyChecker::VERSION,
DependencyChecker::Version,
['file1' => false, __FILE__ => filemtime(__FILE__), 'file3' => false],
[$file => filemtime($file)],
['Dep1'],
Expand Down
4 changes: 2 additions & 2 deletions tests/DI/DecoratorExtension.basic.phpt
Expand Up @@ -77,11 +77,11 @@ services:
$builder = $compiler->getContainerBuilder();

Assert::same(
['a' => true, 'tag' => 2, DI\Extensions\InjectExtension::TAG_INJECT => true, 'Iface' => true],
['a' => true, 'tag' => 2, DI\Extensions\InjectExtension::TagInject => true, 'Iface' => true],
$builder->getDefinition('one')->getTags()
);

Assert::true($builder->getDefinition('one')->getTag(DI\Extensions\InjectExtension::TAG_INJECT));
Assert::true($builder->getDefinition('one')->getTag(DI\Extensions\InjectExtension::TagInject));

Assert::equal([
new Statement([new Reference('self'), 'setup'], ['Service']),
Expand Down
4 changes: 2 additions & 2 deletions tests/DI/DecoratorExtension.factories.accessor.phpt
Expand Up @@ -38,8 +38,8 @@ services:

$builder = $compiler->getContainerBuilder();

Assert::true($builder->getDefinition('foo')->getTag(DI\Extensions\InjectExtension::TAG_INJECT));
Assert::true($builder->getDefinition('foo')->getTag(DI\Extensions\InjectExtension::TagInject));
Assert::null($builder->getDefinition('foo')->getTag('a'));

Assert::null($builder->getDefinition('acc')->getTag(DI\Extensions\InjectExtension::TAG_INJECT));
Assert::null($builder->getDefinition('acc')->getTag(DI\Extensions\InjectExtension::TagInject));
Assert::true($builder->getDefinition('acc')->getTag('a'));
4 changes: 2 additions & 2 deletions tests/DI/DecoratorExtension.factories.phpt
Expand Up @@ -51,10 +51,10 @@ services:

$builder = $compiler->getContainerBuilder();

Assert::true($builder->getDefinition('foo')->getTag(DI\Extensions\InjectExtension::TAG_INJECT));
Assert::true($builder->getDefinition('foo')->getTag(DI\Extensions\InjectExtension::TagInject));
Assert::true($builder->getDefinition('foo')->getTag('a'));
Assert::count(1, $builder->getDefinition('foo')->getResultDefinition()->getSetup());

Assert::true($builder->getDefinition('bar')->getTag(DI\Extensions\InjectExtension::TAG_INJECT));
Assert::true($builder->getDefinition('bar')->getTag(DI\Extensions\InjectExtension::TagInject));
Assert::true($builder->getDefinition('bar')->getTag('a'));
Assert::count(1, $builder->getDefinition('bar')->getResultDefinition()->getSetup());
4 changes: 2 additions & 2 deletions tests/DI/Definitions.Reference.phpt
Expand Up @@ -34,8 +34,8 @@ Assert::false($ref->isSelf());
Assert::same('\a', $ref->getValue());


$ref = new Reference(Reference::SELF);
$ref = new Reference(Reference::Self);
Assert::false($ref->isName());
Assert::false($ref->isType());
Assert::true($ref->isSelf());
Assert::same(Reference::SELF, $ref->getValue());
Assert::same(Reference::Self, $ref->getValue());
2 changes: 1 addition & 1 deletion tests/DI/InjectExtension.basic.phpt
Expand Up @@ -77,7 +77,7 @@ class LastExtension extends DI\CompilerExtension
$this->getContainerBuilder()->addDefinition($this->prefix('one'))
->setType(Service::class)
->addSetup('$e', ['@\ConcreteDependencyA'])
->addTag(Nette\DI\Extensions\InjectExtension::TAG_INJECT);
->addTag(Nette\DI\Extensions\InjectExtension::TagInject);
}
}

Expand Down

0 comments on commit e004976

Please sign in to comment.