Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearchExtension - ability to create factory definitions from interfaces #200

Merged
merged 2 commits into from Jul 24, 2019

Conversation

peldax
Copy link
Contributor

@peldax peldax commented May 10, 2019

  • new feature #196
  • BC break? no

This PR extends SearchExtension to be able to search for interfaces and create factory definitions from them.

WIP is added due to some duplicate code that needs to be refactored.

@peldax
Copy link
Contributor Author

@peldax peldax commented May 10, 2019

@dg I am making tests for this PR and I am wordering what is desirable outcome when factory interface doesnt implement the create() function

  • Skip the interface silently?
  • Throw exception that interface doesnt have the function?

@peldax peldax changed the title [WIP] SearchExtension - ability to create factory definitions from interfaces SearchExtension - ability to create factory definitions from interfaces Jul 8, 2019
@dg dg force-pushed the master branch 7 times, most recently from fecd1fb to 15978c3 Compare Jul 19, 2019
@dg dg merged commit 1237d5d into nette:master Jul 24, 2019
1 check failed
dg pushed a commit that referenced this issue Jul 24, 2019
dg pushed a commit that referenced this issue Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants