-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
addHtml on button stopped working #276
Comments
It is related to #273. I didn't anticipate this use, a possible workaround is: $form->addSubmit('submit', Nette\Utils\Html::el('span')->setText('Submit me')); |
dg
added a commit
that referenced
this issue
Aug 27, 2021
Thank you for the workaround.
But it does NOT work in v3.1.3 and produces:
This clearly is a breaking change. |
I know, I fixed it. |
Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version: 3.1.4
Bug Description
Setting custom html content for a submit button in a form stopped working. The button from example below is rendered empty in v3.1.4 and is rendered as expected in v3.1.3 We sometimes set html inside a button to e.g. add an icon as a specially styled span element.
Steps To Reproduce
Expected Behavior
I would expect the "Submit me" text to appear inside a button element rendered like this:
<button><span>Submit me</span></button>
The output from the code above in v3.1.3 is:
in v 3.1.4 is:
The text was updated successfully, but these errors were encountered: