Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use constructor of mapped type with readonly parameters #294

Closed
SendiMyrkr opened this issue Jan 7, 2023 · 1 comment
Closed

Use constructor of mapped type with readonly parameters #294

SendiMyrkr opened this issue Jan 7, 2023 · 1 comment

Comments

@SendiMyrkr
Copy link
Contributor

SendiMyrkr commented Jan 7, 2023

I think that there should be condition in here https://github.com/nette/forms/blob/master/src/Forms/Container.php#L144 extended for readonly class(PHP 8.2+) and readonly parameters(properties) no matter if parameters are optional or not.

@dg
Copy link
Member

dg commented Jan 19, 2023

Can you elaborate more?

@dg dg closed this as completed Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants