Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot use range() to validate min/max #136

Merged
merged 1 commit into from Sep 26, 2016
Merged

Conversation

@VladaHejda
Copy link
Contributor

VladaHejda commented Sep 15, 2016

When there is different error message for min/max, then checking min or max via range() can cause it fails during min validation for max invalidity (and vice versa) - due to rangeUnderflow/rangeOverflow. Then wrong error message may be shown.

@dg

This comment has been minimized.

Copy link
Member

dg commented Sep 26, 2016

Thanks

@dg dg merged commit ab2fb1b into nette:master Sep 26, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 94.013%
Details
dg added a commit that referenced this pull request Sep 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.