Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility between n:class macro and n:name form macro. #159

Merged
merged 1 commit into from Jul 22, 2017

Conversation

Projects
None yet
2 participants
@xificurk
Copy link
Contributor

xificurk commented Jul 22, 2017

  • bug fix? yes
  • new feature? no
  • BC break? no

Currently n:class and n:name macros do not play well together. The problem is that n:name macro doesn't see n:class as html attribute, so it doesn't reset the class on the returned Html instance of form/label/control. This leads to HTML output with double class="..." attribute.
This PR solves the problem by adding explicit support for n:class into FormMacros.

@xificurk

This comment has been minimized.

Copy link
Contributor Author

xificurk commented Jul 22, 2017

The build failure doesn't seem to be related.

@dg

This comment has been minimized.

Copy link
Member

dg commented Jul 22, 2017

Thanks!

@dg dg merged commit 4d3e819 into nette:master Jul 22, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
coverage/coveralls Coverage increased (+0.01%) to 94.701%
Details

@xificurk xificurk deleted the xificurk:form-macros-nclass-support branch Jul 22, 2017

dg added a commit that referenced this pull request Jul 24, 2017

dg added a commit that referenced this pull request Aug 25, 2017

xificurk added a commit to nepada/form-renderer that referenced this pull request Aug 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.