Fix compatibility between n:class macro and n:name form macro. #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build failure doesn't seem to be related. |
|
Thanks! |
dg
pushed a commit
that referenced
this pull request
Jul 24, 2017
dg
pushed a commit
that referenced
this pull request
Jul 24, 2017
dg
pushed a commit
that referenced
this pull request
Aug 25, 2017
xificurk
added a commit
to nepada/form-renderer
that referenced
this pull request
Aug 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
n:classandn:namemacros do not play well together. The problem is thatn:namemacro doesn't seen:classas html attribute, so it doesn't reset the class on the returned Html instance of form/label/control. This leads to HTML output with doubleclass="..."attribute.This PR solves the problem by adding explicit support for
n:classintoFormMacros.