Use self::TypeDate as default for DateTimeControl::$type, not self::Date
#325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to be an unwanted change introduced in 3.2.1 in 01039d1
spaze
force-pushed
the
spaze/constant-type-date
branch
from
524707b
to
45da226
Compare
spaze
added a commit
to spaze/michalspacek.cz
that referenced
this pull request
Mar 30, 2024
spaze
added a commit
to spaze/michalspacek.cz
that referenced
this pull request
Mar 30, 2024
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
self::TypeDateas default forDateTimeControl::$type, notself::DateThis seems to be an unwanted change introduced in 3.2.1 in 01039d1.
Also reported by PHPStan here https://github.com/nette/forms/actions/runs/8458879610/job/23174056805#step:5:164