Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netteForms.js: Show all error messages at once #65

Closed
wants to merge 3 commits into from

Conversation

@hranicka
Copy link
Contributor

hranicka commented Feb 18, 2015

Nette shows only the first form error. And after user reparation shows the next error etc.

I think show all errors at once is more user friendly.
So I've created PR which adds this behavior.

I think it will be necessary work on it before merge (eg. add options like "show one by one error"/"show all errors at once").

What do you think about that?

/**
* Shows an alert.
*/
Nette.alert = function(message) {

This comment has been minimized.

Copy link
@hranicka

hranicka Feb 18, 2015

Author Contributor

I've added this while I'm working on "show all messages at once".

Tt would be nice to have an option redefine "show alert" function and create custom handlers.

@dg dg force-pushed the nette:master branch 2 times, most recently from 131f7d2 to 532059a May 21, 2015
Conflicts:
	src/assets/netteForms.js
@hranicka

This comment has been minimized.

Copy link
Contributor Author

hranicka commented May 23, 2015

I've updated the PR and resolved merge conflicts with current master.

It changes current behavior of error alerts, see my original comment.

Client can override Nette.showErrors and Nette.alert with custom behavior.

@janedbal

This comment has been minimized.

Copy link

janedbal commented May 23, 2015

👍 for showing all errors at once

@hranicka

This comment has been minimized.

Copy link
Contributor Author

hranicka commented May 23, 2015

@janedbal I don't like (as common web user) one-by-one error.
I like to know all errors and fix them at once.

Instead of repair error, send form, get another error, repair another error, send form, ...

@hranicka hranicka force-pushed the hranicka:feature/alert-messages branch from 4b40023 to 6313660 May 27, 2015
@dg dg force-pushed the nette:master branch 2 times, most recently from a57a557 to 55d0eb8 Jun 19, 2015
@dg dg force-pushed the nette:master branch from ec29b6d to 249f516 Nov 29, 2015
@dg dg force-pushed the nette:master branch from 728c43e to ffb3b6b Jan 11, 2016
@dg dg force-pushed the nette:master branch 2 times, most recently from 9e359e6 to fa84d63 Mar 30, 2016
@dg dg force-pushed the nette:master branch 2 times, most recently from 3c1619a to 31bc0a3 Apr 11, 2016
@dg dg force-pushed the nette:master branch 7 times, most recently from 6b04b51 to d1c30d6 Apr 20, 2016
@dg dg force-pushed the nette:master branch 4 times, most recently from 2b19f43 to fd381fb May 13, 2016
@dg dg force-pushed the nette:master branch from fd381fb to b70e5da May 19, 2016
@dg dg force-pushed the nette:master branch 7 times, most recently from 81549c5 to 98832d3 Jun 1, 2016
@dg dg force-pushed the nette:master branch from 27cf0d0 to 31b9298 Jun 14, 2016
@dg dg force-pushed the nette:master branch 6 times, most recently from 2b44619 to 4473513 Jun 29, 2016
@dg dg closed this in a357520 Jun 30, 2016
dg added a commit that referenced this pull request Jun 30, 2016
@dg

This comment has been minimized.

Copy link
Member

dg commented Jun 30, 2016

Merged, thanks.

dg added a commit that referenced this pull request Jun 30, 2016
dg added a commit that referenced this pull request Jun 30, 2016
dg added a commit that referenced this pull request Jun 30, 2016
dg added a commit that referenced this pull request Jun 30, 2016
dg added a commit that referenced this pull request Jun 30, 2016
dg added a commit that referenced this pull request Jun 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.