netteForms.js: Show all error messages at once #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /** | ||
| * Shows an alert. | ||
| */ | ||
| Nette.alert = function(message) { |
There was a problem hiding this comment.
I've added this while I'm working on "show all messages at once".
Tt would be nice to have an option redefine "show alert" function and create custom handlers.
dg
force-pushed
the
master
branch
2 times, most recently
from
131f7d2
to
532059a
Compare
Conflicts: src/assets/netteForms.js
|
I've updated the PR and resolved merge conflicts with current It changes current behavior of error alerts, see my original comment. Client can override |
|
👍 for showing all errors at once |
|
@janedbal I don't like (as common web user) one-by-one error. Instead of repair error, send form, get another error, repair another error, send form, ... |
hranicka
force-pushed
the
feature/alert-messages
branch
from
4b40023
to
6313660
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
a57a557
to
55d0eb8
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
9e359e6
to
fa84d63
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
3c1619a
to
31bc0a3
Compare
dg
force-pushed
the
master
branch
7 times, most recently
from
6b04b51
to
d1c30d6
Compare
dg
force-pushed
the
master
branch
4 times, most recently
from
2b19f43
to
fd381fb
Compare
dg
force-pushed
the
master
branch
7 times, most recently
from
81549c5
to
98832d3
Compare
dg
force-pushed
the
master
branch
6 times, most recently
from
2b44619
to
4473513
Compare
dg
pushed a commit
that referenced
this pull request
Jun 30, 2016
|
Merged, thanks. |
dg
pushed a commit
that referenced
this pull request
Jun 30, 2016
dg
pushed a commit
that referenced
this pull request
Jun 30, 2016
dg
pushed a commit
that referenced
this pull request
Jun 30, 2016
dg
pushed a commit
that referenced
this pull request
Jun 30, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nette shows only the first form error. And after user reparation shows the next error etc.
I think show all errors at once is more user friendly.
So I've created PR which adds this behavior.
I think it will be necessary work on it before merge (eg. add options like "show one by one error"/"show all errors at once").
What do you think about that?