PHP 7.2 - deprecated "each" calls

[remicollet]

• bug report? yes
• feature request? no
• version: 2.4.2

Running security test suite

-- FAILED: SecurityExtension | tests/Security.DI/SecurityExtension.user.phpt
   Exited with error code 255 (expected 0)
   E_DEPRECATED: The each() function is deprecated. This message will be suppressed on further calls

[remicollet]

Same issue with Forms test suite

-- FAILED: Nette\Forms HTTP data. | tests/Forms/Forms.submittedBy.phpt
   Exited with error code 255 (expected 0)
   E_DEPRECATED: The each() function is deprecated. This message will be suppressed on further calls

[dg]

Is there file name and line where error is occured?

[remicollet]

Full output

-- FAILED: /dev/shm/BUILD/security-8a3051f9b16d4d7bfa18b6b0ff6f9f6f418f9801/tests/Security.DI/SecurityExtension.user.phpt
   Exited with error code 255 (expected 0)
   E_DEPRECATED: The each() function is deprecated. This message will be suppressed on further calls
   
   in Nette/Http/RequestFactory.php(114) 
   in Nette/Http/RequestFactory.php(114) each()
   in tests/Security.DI/SecurityExtension.user.phpt(22) : eval()'d code(63) Nette\Http\RequestFactory->createHttpRequest()
   in Nette/DI/Container.php(178) Container->createServiceFoo__request()
   in Nette/DI/Container.php(104) Nette\DI\Container->createService()
   in tests/Security.DI/SecurityExtension.user.phpt(22) : eval()'d code(42) Nette\DI\Container->getService()
   in Nette/DI/Container.php(178) Container->createServiceBar__session()
   in Nette/DI/Container.php(104) Nette\DI\Container->createService()
   in tests/Security.DI/SecurityExtension.user.phpt(22) : eval()'d code(92) Nette\DI\Container->getService()
   in Nette/DI/Container.php(178) Container->createServiceSecurity__userStorage()
   in Nette/DI/Container.php(104) Nette\DI\Container->createService()
   in tests/Security.DI/SecurityExtension.user.phpt(25) Nette\DI\Container->getService()

[remicollet]

AFAICS, each is only used in Nette/Http/RequestFactory.php (grep in all the framework)

[dg]

There should be @ operator to silent notice.

[xificurk]

@dg There is, but only in 2.4-dev, there is no stable version with this fix yet.

[remicollet]

silent operator = the rope to hang yourself.

-			while (list($key, $val) = each($list)) {
+			foreach ($list as $key => $val) {

[JanTvrdik]

@remicollet See commit message of 4667ae0

foreach ($arr as &$el) fails in PHP 5.6 with single-item array

[dg]

How it is possible that tests do not pass when there is a silent operator?

If you use your own error handler, you need to modify it as follows https://github.com/nette/code-checker/blob/master/src/bootstrap.php#L24-L26

[dg]

fixed 4667ae0