Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

session - read_and_close #155

Closed
mabar opened this issue Jun 17, 2019 · 2 comments · Fixed by #156
Closed

session - read_and_close #155

mabar opened this issue Jun 17, 2019 · 2 comments · Fixed by #156

Comments

@mabar
Copy link
Contributor

mabar commented Jun 17, 2019

session_start() supports option read_and_close which could massively increase performance in apps with multiple simultaneous requests. It would be nice to allow configuration of this directive. I can send PR if needed.

https://www.php.net/manual/en/function.session-start.php
@dg
Copy link
Member

dg commented Jun 18, 2019

How would you suggest to set this option?

@mabar
Copy link
Contributor Author

mabar commented Jun 18, 2019 •
edited

I would add it to options https://github.com/nette/http/blob/master/src/Bridges/HttpDI/SessionExtension.php#L77

And add it to constructor arguments. https://github.com/nette/http/blob/master/src/Bridges/HttpDI/SessionExtension.php#L52

I can try send a PR

@mabar mabar mentioned this issue Jun 18, 2019
Merged
@dg dg closed this as completed in #156 Jul 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Session: read_and_close configuration mabar/http
2 participants
@dg @mabar