Unify and fix host parsing in RequestFactory #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks |
dg
added a commit
that referenced
this pull request
Nov 14, 2023
Co-authored-by: David Grudl <david@grudl.com>
dg
added a commit
that referenced
this pull request
Nov 14, 2023
Co-authored-by: David Grudl <david@grudl.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of
useForwardedProxyremoves square brackets around the host filled into the resulting URL, which conflicts with RFC 3986. The specifications state that an IPv6 host should always be encapsulated in square brackets - correctly implemented in thegetServermethod. This PR introduces a new methodparseHost, which is now used in both of these methods to unify the implementation.