Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not suppress 'permission denied' warnings in FileUpload::move() #82

Closed
wants to merge 3 commits into from
Closed

Do not suppress 'permission denied' warnings in FileUpload::move() #82

wants to merge 3 commits into from

Commits on Mar 1, 2016

  1. Do not suppress 'permission denied' warnings in FileUpload::move() 

    This commit adds more comprehensible error reporting to the `move()` method in the following scenarios:

* Say the program has insufficient permissions to create the directory `dirname($dest)`. With this commit the `move()` method correctly raises `mkdir(): Permission denied` warning instead of warning raised by `move_uploaded_file`: `failed to open stream: No such file or directory` with previous code.
* Or the already existing file at `$dest` may not be deleted with the current permissions. With this commit a correct `Permission denied` warning is again raised by `unlink` instead of warning raised by `move_uploaded_file` with previous code.
    @OndrejSlamecka
    OndrejSlamecka committed Mar 1, 2016
    Copy the full SHA
    d86e04a View commit details
    Browse the repository at this point in the history

  2. Avoid the race condition from previous commit

    @OndrejSlamecka
    OndrejSlamecka committed Mar 1, 2016
    Copy the full SHA
    ce050e5 View commit details
    Browse the repository at this point in the history

  3. Rewrite incorrect error description

    @OndrejSlamecka
    OndrejSlamecka committed Mar 1, 2016
    Copy the full SHA
    3ddf66f View commit details
    Browse the repository at this point in the history