Content aware filters WIP #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dg
force-pushed
the
filters2
branch
4 times, most recently
from
00ca443
to
409da5c
Compare
|
I think that silent conversion html -> text would not be there. |
| public $contentType; | ||
|
|
||
|
|
||
| public function __construct($contentType = NULL) |
There was a problem hiding this comment.
is it neccesary to create new instance every time? Imho this could be made into flyweight.
There was a problem hiding this comment.
It might, but creating an instance is extreme cheap (and is used rarely)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://forum.nette.org/cs/26286-latte-a-plaintextove-versus-blokove-filtry