Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting the $self variable in SmtpMailer manually #45

Closed
janbuchar opened this issue Sep 7, 2017 · 2 comments · Fixed by #46
Closed

Allow setting the $self variable in SmtpMailer manually #45

janbuchar opened this issue Sep 7, 2017 · 2 comments · Fixed by #46

Comments

@janbuchar
Copy link
Contributor

  • bug report? no
  • feature request? yes
  • version: 2.4.0

Description

It would be great if we could set the $self variable (https://github.com/nette/mail/blob/master/src/Mail/SmtpMailer.php#L133) manually (e.g using config parameters) - if it's set to localhost, some mail servers consider our mails spam. Our use case is sending e-mails from the CLI, where it makes no sense to set the HTTP_HOST variable used by SmtpMailer.
@dg
Copy link
Member

dg commented Sep 7, 2017

Can you send pull request?

@janbuchar
Copy link
Contributor Author

Of course, as soon as I think of a meaningful name for the option.

@janbuchar janbuchar mentioned this issue Sep 13, 2017
Merged
@dg dg closed this as completed in #46 Sep 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SmtpMailer: allow setting the client name through config
2 participants
@dg @janbuchar