Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid is_numeric in Nette\Security\Identity::setId #1520

Closed
thorewi opened this issue Jan 18, 2015 · 1 comment
Closed

avoid is_numeric in Nette\Security\Identity::setId #1520

thorewi opened this issue Jan 18, 2015 · 1 comment

Comments

@thorewi
Copy link

thorewi commented Jan 18, 2015

because: http://php.net/manual/en/function.is-numeric.php#102011

it causes problems for example with google ids, which are really big.
@thorewi
Copy link
Author

thorewi commented Jan 18, 2015

maybe

$this->id = (is_numeric($id) && $id === (string)(1*$id)) ? 1*$id : $id;

would help.

dg added a commit to nette/security that referenced this issue Feb 20, 2015
@dg
Identity: fixed conversion of big ints [Closes nette/nette#1520]
f18b4b9
dg added a commit that referenced this issue Mar 14, 2015
@dg
Identity: fixed conversion of big ints [Closes #1520]
580827a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thorewi