Database: iterate over exact count of columns in Statement::detectColumnTypes() #1028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be nice to add note about php bug (or create it). |
| @@ -159,8 +159,9 @@ private function detectColumnTypes() | |||
| if ($this->types === NULL) { | |||
| $this->types = array(); | |||
| if ($this->connection->getSupplementalDriver()->isSupported(ISupplementalDriver::SUPPORT_COLUMNS_META)) { // workaround for PHP bugs #53782, #54695 | |||
| $col = 0; | |||
| while ($meta = $this->pdoStatement->getColumnMeta($col++)) { | |||
| $cnt = $this->pdoStatement->columnCount(); | |||
There was a problem hiding this comment.
I'd use $count instead of $cnt. Nice bug by the way. 👍
|
@hrach Sqlsrv extension is for Win only and Microsoft maintains it. I don't know where to send bug report. And to be honest, I don't want to :) |
|
@milo Well, sometime I have apache crash during the test run. It's just win error dialog, everythink runs ok, so I have suspision it's not only about sqldrive... ;) |
…umnTypes() PHP process is killed when trying get meta info for column number bigger then real count with MS Sqlsrv PDO driver.
You can submit it to bugs.php.net, there's a package sqlsrv, that should be enough. :) |
Maybe later. If so, I must read php bugs howto, create backtrace.... |
|
Merged e6ab55e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP process is killed when trying get meta info for column number bigger then real count with MS Sqlsrv PDO driver.
Hope, that old behaviour does not hide some side effect.