Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SimpleAuthenticator: roles support #1434

Closed
wants to merge 1 commit into from
Closed

SimpleAuthenticator: roles support #1434

wants to merge 1 commit into from

Conversation

matej21
Copy link
Contributor

@matej21 matej21 commented Mar 5, 2014

@JanTvrdik
Copy link
Contributor

Nice, few notes:

  • Constructor docBlock needs to updated
  • I think it will be better to normalize and validate $userlist structure in constructor.
  • $pass -> $password

@matej21
Copy link
Contributor Author

matej21 commented Mar 5, 2014

  1. agree, also this comment in NetteExtension needs to be updated. I will do it tomorrow (eh.. today)
  2. disagree, my solution is more lazy. It is unnecessary to normalize that structure every time you initialize Authenticator (which is required by Security\User)
  3. cannot use "password", variable with this name is used for input password

@dg
Copy link
Member

dg commented Mar 5, 2014

Structure should be normalized in NetteExtension. Then roles should be second argument in constructor.

@matej21
Copy link
Contributor Author

matej21 commented Mar 5, 2014

updated

@dg
Copy link
Member

dg commented Mar 5, 2014

Merged db34463

@dg dg closed this Mar 5, 2014
@matej21 matej21 deleted the feature/simpleAuthenticatorRoles branch March 19, 2014 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1-feature 2-security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@matej21 @JanTvrdik @dg @hrach