Printer: fixed falsy Attribute aren't printed (#142)

nette · Sep 29, 2023 · 7eb1b35 · 7eb1b35
1 parent c0b51b6
commit 7eb1b35
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/PhpGenerator/Printer.php b/src/PhpGenerator/Printer.php
@@ -424,7 +424,7 @@ protected function printAttributes(array $attrs, bool $inline = false): string
 		foreach ($attrs as $attr) {
 			$args = $this->dumper->format('...?:', $attr->getArguments());
 			$args = Helpers::simplifyTaggedNames($args, $this->namespace);
-			$items[] = $this->printType($attr->getName(), nullable: false) . ($args ? "($args)" : '');
+			$items[] = $this->printType($attr->getName(), nullable: false) . ($args === '' ? '' : "($args)");
 			$inline = $inline && !str_contains($args, "\n");
 		}
 

diff --git a/tests/PhpGenerator/ClassType.attributes.phpt b/tests/PhpGenerator/ClassType.attributes.phpt
@@ -41,6 +41,6 @@ $method = $class->addMethod('getHandle')
 $method->addParameter('mode')
 	->addComment('comment')
 	->addAttribute('ExampleAttribute')
-	->addAttribute('WithArguments', [123]);
+	->addAttribute('WithArguments', [0]);
 
 sameFile(__DIR__ . '/expected/ClassType.attributes.expect', (string) $class);
diff --git a/tests/PhpGenerator/expected/ClassType.attributes.expect b/tests/PhpGenerator/expected/ClassType.attributes.expect
@@ -22,7 +22,7 @@ class Example
 	#[ExampleAttribute]
 	public function getHandle(
 		/** comment */
-		#[ExampleAttribute, WithArguments(123)]
+		#[ExampleAttribute, WithArguments(0)]
 		$mode,
 	) {
 	}