Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method::from($from) loads method body as well #4

Closed
wants to merge 1 commit into from

Conversation

uestla
Copy link
Contributor

@uestla uestla commented Jul 4, 2014

No description provided.

@dg
Copy link
Member

@dg dg commented Jul 4, 2014

Can you add a test please?

(Test it with some class from minified Nette and PDO)

@mishak87
Copy link

@mishak87 mishak87 commented Jul 4, 2014

❤️ Awesome! But I guess it won't pass for B::b of this source.

<?php class A{function a(){return 'Aa';}}class B{function a(){return'Ba';} function b() {return'Bb';}function c(){return'Bc';}}class C{function a() {return'Ca';}}

Basically you would need to parse php code with context buffer to make it bullet proof and use begin and end for optimization.

@uestla
Copy link
Contributor Author

@uestla uestla commented Jul 4, 2014

@mishak87 Right ... Not to mention multiple namespaces and all that on one line...
Closing.

@uestla uestla closed this Jul 4, 2014
@mishak87
Copy link

@mishak87 mishak87 commented Jul 4, 2014

I didn't mean to discourage you from doing it. Such feature would be really useful ie. it could simplify significantly generation of certain proxies. Probably it would be better to lazy load it for performance reasons but it is possible to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants