Passwords: Fix for validation of cost 31 [Closes #2] #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you think you could add a test case? |
|
Hehe, I thought someone will probably ask. Well, I had the test written before the fix. I actually am fan of TDD. It would verify that the bug is there in the first place. But after some time of wondering why tests seem to not run at all, it turns out computers have hard time calculating hash with cost 31 and the test would never complete on my PC, so I just deleted it. I think it's not worth the trouble for such a trivial thing. |
|
Anyway, I read that article by dg last week and use it to advocate unit testing in our company ;-) |
| @@ -54,7 +54,7 @@ public static function hash($password, array $options = NULL) | |||
| public static function verify($password, $hash) | |||
| { | |||
| return preg_match('#^\$2y\$(?P<cost>\d\d)\$(?P<salt>.{22})#', $hash, $m) | |||
| && $m['cost'] > 3 && $m['cost'] < 31 | |||
| && $m['cost'] >= 4 && $m['cost'] <= 31 | |||
There was a problem hiding this comment.
I think it is better to use same magic numbers everywhere and use >= instead of > as it is less confusing and error prone.
dg
pushed a commit
that referenced
this pull request
Aug 24, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.