Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tester tries to run private test methods and marks them as passing #62

Closed
paranoiq opened this issue Dec 8, 2013 · 2 comments
Closed

Comments

@paranoiq
Copy link

paranoiq commented Dec 8, 2013

class SomeTest extends TestCase
{

    private function testAaa()
    {
        Assert::fail('aaa');
    }
}

it should notify the user instead

happens only when runned with TestRunner. not directly

@milo
Copy link
Member

milo commented Dec 11, 2013

I don't know if private test methods should be somehow runned. Maybe fail test result is better to suppress author expectation that it was runned.

@paranoiq
Copy link
Author

the test should fail and inform the programmer, that he is an idiot and he should either rename the method or make it public. current behavior is very confusing, because when typing fast and using IDE shortcuts you can write "private" by accident and not even notice it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants