Code coverage fixes [Closes #105] #106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Message rendering in third commit is just quick idea. Maybe report would deserve facelift at all. |
|
Hmmm, dependency on environment variable inside Collector smells. What do you think about this #107? |
|
If you want to leave manual |
|
Manual Collector::start will be always possible. |
|
Yes, but data will append as now and datafile must be deleted manualy. But I'm OK with #107, I like it! |
|
I am not sure if appending data is wanted or unwanted behavior… |
|
Me neither. I guess when someone runs coverage manually he should take care about empty data file manually too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.