Skip to content

Code coverage fixes [Closes #105] #106

Closed
wants to merge 3 commits into from

2 participants

@milo
Nette Foundation member
milo commented Mar 5, 2014

No description provided.

@milo
Nette Foundation member
milo commented Mar 5, 2014

Message rendering in third commit is just quick idea. Maybe report would deserve facelift at all.

@dg
Nette Foundation member
dg commented Mar 5, 2014

Hmmm, dependency on environment variable inside Collector smells. What do you think about this #107?

@milo
Nette Foundation member
milo commented Mar 5, 2014

If you want to leave manual Collector::start() calling in favour of --coverage then :+1:
Only manual run php test.phpt will not run coverage but it is OK imo.

@dg
Nette Foundation member
dg commented Mar 5, 2014

Manual Collector::start will be always possible.

@milo
Nette Foundation member
milo commented Mar 5, 2014

Yes, but data will append as now and datafile must be deleted manualy. But I'm OK with #107, I like it!

@milo milo closed this Mar 5, 2014
@dg
Nette Foundation member
dg commented Mar 5, 2014

I am not sure if appending data is wanted or unwanted behavior…

@milo
Nette Foundation member
milo commented Mar 5, 2014

Me neither. I guess when someone runs coverage manually he should take care about empty data file manually too.

@milo milo deleted the milo:pull-coverage branch Mar 6, 2014
@dg dg referenced this pull request Mar 8, 2014
Closed

CodeCoverage always appends data #105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.